Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(meta): do not split small table from default group #16919

Closed
wants to merge 8 commits into from
Closed

feat(meta): do not split small table from default group #16919

wants to merge 8 commits into from

Conversation

Little-Wallace
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@Little-Wallace Little-Wallace force-pushed the wallace/do-not-split-small-group branch from d15f964 to a4a2c69 Compare May 27, 2024 02:25
@gitguardian GitGuardian
Copy link

gitguardian bot commented May 27, 2024 •
edited
Loading

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@Little-Wallace
Squashed commit of the following:
bcf50b6 
commit 3cafafa19b4e8423a19d8fbf757c177f7c6cbe9f
Author: Little-Wallace <[email protected]>
Date:   Tue May 28 12:18:04 2024 +0800

    adjust strategy

    Signed-off-by: Little-Wallace <[email protected]>

commit a4a2c69
Author: Little-Wallace <[email protected]>
Date:   Mon May 27 10:24:49 2024 +0800

    do not split small group

    Signed-off-by: Little-Wallace <[email protected]>

Signed-off-by: Little-Wallace <[email protected]>
@Little-Wallace
adjust strategy
e4c9ec1 
Signed-off-by: Little-Wallace <[email protected]>
@Little-Wallace Little-Wallace force-pushed the wallace/do-not-split-small-group branch from 9526a2a to e4c9ec1 Compare May 28, 2024 04:41
@Little-Wallace
fix small table intra compact
fabbb96 
Signed-off-by: Little-Wallace <[email protected]>
@Little-Wallace Little-Wallace force-pushed the wallace/do-not-split-small-group branch from a99f3fa to fabbb96 Compare May 28, 2024 10:00
@Little-Wallace
adjust base level size
30f251f 
Signed-off-by: Little-Wallace <[email protected]>
@Little-Wallace Little-Wallace force-pushed the wallace/do-not-split-small-group branch from f811e03 to 30f251f Compare May 29, 2024 02:49
@Little-Wallace
partition virtual lsm tree
ce4130a 
Signed-off-by: Little-Wallace <[email protected]>
@Little-Wallace Little-Wallace force-pushed the wallace/do-not-split-small-group branch 2 times, most recently from f8df657 to aa9b120 Compare May 30, 2024 06:37
@Little-Wallace Little-Wallace marked this pull request as ready for review May 30, 2024 09:40
@Little-Wallace
add some metrics
d7c20a3 
Signed-off-by: Little-Wallace <[email protected]>
@Little-Wallace Little-Wallace force-pushed the wallace/do-not-split-small-group branch from 99c2f93 to d7c20a3 Compare May 31, 2024 08:36
This was referenced Jun 4, 2024
Open
Open
@github-actions GitHub Actions
Copy link
Contributor

This PR has been open for 60 days with no activity.

If it's blocked by code review, feel free to ping a reviewer or ask someone else to review it.

If you think it is still relevant today, and have time to work on it in the near future, you can comment to update the status, or just manually remove the no-pr-activity label.

You can also confidently close this PR to keep our backlog clean. (If no further action taken, the PR will be automatically closed after 7 days. Sorry! 🙏)
Don't worry if you think the PR is still valuable to continue in the future.
It's searchable and can be reopened when it's time. 😄

@github-actions GitHub Actions
Copy link
Contributor

Close this PR as there's no further actions taken after it is marked as stale for 7 days. Sorry! 🙏

You can reopen it when you have time to continue working on it.

@github-actions github-actions bot closed this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci/run-e2e-single-node-tests no-pr-activity type/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Little-Wallace